8386637: PPC64: Implement Thread.onSpinWait() intrinsic and SpinPause using SMT priority hints#31513
8386637: PPC64: Implement Thread.onSpinWait() intrinsic and SpinPause using SMT priority hints#31513dbriemann wants to merge 1 commit into
Conversation
…() using SMT priority hints
|
👋 Welcome back dbriemann! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@dbriemann The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
|
Nice improvement! You need to fix the title mismatch (see above). |
2 participants
Benchmarking with ThreadOnSpinWaitProducerConsumer.java on Power10 with SMT8
have shown the following results:
Pinning the HW threads to the same core via
taskset -c 0,2:intrinsic disabled: 1490.2 us/op
intrinsic enabled: 340.3 us/op
=> 4.4x performance
Pinning the HW threads to different cores via
taskset -c 0,8:intrinsic disabled: 1047.8 µs/op
intrinsic enabled: 804.4 µs/op
=> 1.3x performance
Single hardware thread (taskset -c 0):
intrinsic disabled: 1614.9 µs/op
intrinsic enabled: 1863.3 µs/op
=> 0.87x performance (slight regression)
The slight regression on 1 HW thread seems negligible since that scenario is highly unlikely on modern processors.
Progress
Integration blocker
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31513/head:pull/31513$ git checkout pull/31513Update a local copy of the PR:
$ git checkout pull/31513$ git pull https://git.openjdk.org/jdk.git pull/31513/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31513View PR using the GUI difftool:
$ git pr show -t 31513Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31513.diff
Using Webrev
Link to Webrev Comment